Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create NPM node #6177

Merged
merged 2 commits into from
May 10, 2023
Merged

feat: Create NPM node #6177

merged 2 commits into from
May 10, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 3, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/new Creation of an entirely new node labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 72.97% and project coverage change: +0.01 🎉

Comparison is base (6eed763) 19.94% compared to head (d32a413) 19.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6177      +/-   ##
==========================================
+ Coverage   19.94%   19.96%   +0.01%     
==========================================
  Files        2647     2651       +4     
  Lines      119686   119722      +36     
  Branches    18933    18933              
==========================================
+ Hits        23876    23903      +27     
- Misses      95082    95091       +9     
  Partials      728      728              
Impacted Files Coverage Δ
packages/core/src/NodeExecuteFunctions.ts 14.47% <0.00%> (ø)
...ackages/nodes-base/nodes/Npm/DistTagDescription.ts 33.33% <33.33%> (ø)
...ackages/nodes-base/nodes/Npm/PackageDescription.ts 73.68% <73.68%> (ø)
...kages/nodes-base/credentials/NpmApi.credentials.ts 100.00% <100.00%> (ø)
packages/nodes-base/nodes/Npm/Npm.node.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Joffcom
Joffcom previously approved these changes May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit f3bc6f1 into master May 10, 2023
@netroy netroy deleted the npm-node branch May 10, 2023 10:37
MiloradFilipovic added a commit that referenced this pull request May 11, 2023
* master:
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
  ci: Fix linting issue on master (no-changelog) (#6222)
  fix(core): Ensure DB repositories are initialized before the DB migrations are run  (#6220)
  refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642)
  ci: Increase timeout for DB tests (no-changelog) (#6221)
  fix(editor): Fix viewing and downloading of binary data (#6218)
  fix: Prevent unnecessary error messages also for data loaded flag (#6201)
  feat: Create NPM node (#6177)
  fix(editor): Fix polling trigger check for `runData` (#6130)
  ci: Fix linting issue on master (no-changelog) (#6217)
  fix: Prevent overflow when rendering expression hints (#6214)
  feat(core): Improve health check (#6205)
  refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204)
  fix(editor): Add loading skeletons to Executions list page (#6184)
  ci: Fix v1 docker rc builds (no-changelog) (#6208)
  feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209)
  fix: Correctly save executions that failed when polling as error instead of new (#6192)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputList.vue
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants