Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Correctly doesn't redirect on non GET method #6132

Merged
merged 2 commits into from
May 4, 2023

Conversation

agobrech
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/http-node-with-post-method-ignores-follow-redirects-disabled/24245?u=mutedjam

@agobrech agobrech changed the title fix(Node HTTP Request): Correctly doesn't redirect on Post fix(Node HTTP Request): Correctly doesn't redirect on non GET method Apr 28, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title fix(Node HTTP Request): Correctly doesn't redirect on non GET method fix(HTTP Request Node): Correctly doesn't redirect on non GET method Apr 28, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3074f42) 19.97% compared to head (ea203f3) 19.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6132      +/-   ##
==========================================
- Coverage   19.97%   19.97%   -0.01%     
==========================================
  Files        2621     2621              
  Lines      118071   118073       +2     
  Branches    18520    18521       +1     
==========================================
  Hits        23585    23585              
- Misses      93774    93775       +1     
- Partials      712      713       +1     
Impacted Files Coverage Δ
...s/nodes-base/nodes/HttpRequest/HttpRequest.node.ts 100.00% <ø> (ø)
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 30.76% <0.00%> (-0.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@agobrech agobrech requested a review from maspio May 4, 2023 07:33
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 3f5c606 into master May 4, 2023
@agobrech agobrech deleted the node-409-http-request-follow-redirects-false-is branch May 4, 2023 07:55
MiloradFilipovic added a commit that referenced this pull request May 5, 2023
* master: (110 commits)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  feat(Kafka Trigger Node): Add non-parallel execution (#6175)
  fix(Postgres Node): Always return TIMESTAMP and TIMESTAMPZ as ISO string (#6145)
  fix: Revert change that hid the SSH private key (no-changelog) (#6158)
  fix(Google Sheets Node): Upgrade xlsx to address CVE-2023-30533 (#6172)
  fix(editor): Show the correct actions count in the nodes list (#6183)
  ci: Revert full db reset for e2e (no-changelog) (#6182)
  fix(AWS Rekognition Node): Fix all different action type (#6136)
  feat(Airtable Node): Access token support (#6160)
  fix(editor): Remove duplicate mapping of `item.json` key in data pinning (#6135)
  fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
  fix(MySQL Node): Node should return date types as strings (#6169)
  feat(JotForm Trigger Node): Add support for hipaa-api.jotform.com (#6171)
  🚀 Release 0.227.0 (#6167)
  fix(editor): Flag issues only on workflow activation (#6127)
  fix(editor): Faster reconnects for push (no-changelog) (#6164)
  fix: Log unhandled errors during license activation (no-changelog) (#6165)
  ...

# Conflicts:
#	packages/editor-ui/src/mixins/workflowHelpers.ts
#	packages/editor-ui/src/views/NodeView.vue
netroy pushed a commit that referenced this pull request May 15, 2023
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants