fix(core): Align concurrency and timeout defaults between instance and runner #12503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
reviewed
Jan 8, 2025
| @Env('N8N_RUNNERS_MAX_CONCURRENCY') | ||
| maxConcurrency: number = 5; | ||
| maxConcurrency: number = 10; |
There was a problem hiding this comment.
what's the reason to define these a second time? could we delete these, and use TaskRunnersConfig from the config package instead?
There was a problem hiding this comment.
Task runner and n8n are two separate executables. It feels a weird to share the same configuration between them, especially since the configuration items they use are not 1:1. What we could do is to extract the shared parts into its own class and share that between n8n and task runner.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
align-concurrency-and-timeout-defaults-between-instance-and-runner
|
| Run status |
|
| Run duration | 04m 55s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
ivov
deleted the
align-concurrency-and-timeout-defaults-between-instance-and-runner
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12496