Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Increase default concurrency and timeout in task runners #12496

Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 8, 2025

Summary

Increase default values for N8N_RUNNERS_MAX_CONCURRENCY and N8N_RUNNERS_TASK_TIMEOUT to approximate historical Code node behavior. We will reduce these back to more conservative values with n8n v2.

Related Linear tickets, Github issues, and Community forum posts

Context: https://n8nio.slack.com/archives/C035KBDA917/p1736150633407259

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 8, 2025
Copy link

cypress bot commented Jan 8, 2025

n8n    Run #8649

Run Properties:  status check passed Passed #8649  •  git commit 1dfaaec8f2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review increase-default-concurrency-and-timeout-in-task-runners
Run status status check passed Passed #8649
Run duration 04m 48s
Commit git commit 1dfaaec8f2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@ivov ivov merged commit 4182095 into master Jan 8, 2025
37 checks passed
@ivov ivov deleted the increase-default-concurrency-and-timeout-in-task-runners branch January 8, 2025 10:25
@tomi
Copy link
Contributor

tomi commented Jan 8, 2025

@ivov we need update the timeout also in the runner config here.

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants