fix(core): Return unredacted credentials from GET credentials/:id
#12447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
tomi
approved these changes
Jan 7, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2424-not-possible-to-reconnect-google-credentials
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
484
|
| View all changes introduced in this branch ↗︎ | |
despairblue
deleted the
pay-2424-not-possible-to-reconnect-google-credentials
branch
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't redact secrets in credentials for
GET /credentials/:id. The FE will send back all of the data onPATCH /credentials/:id, so if we redact on GET we end up saving the redacted value to the DB on PATCH.Long term fix should be to identify the redacted values and don't updated them in the db. E.g. only update passwords if the user inserted a new one. In general secrets should not be send back to the FE at all to prevent accidentally leaking them. But that's goal for another PR.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2424/not-possible-to-reconnect-google-credentials
Review / Merge checklist
Tests included.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)