fix(editor): Polyfill crypto.randomUUID #12052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
added
the
release/backport
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
alexgrozav
approved these changes
Dec 5, 2024
alexgrozav
reviewed
Dec 5, 2024
Comment on lines
+21
to
+24
| // Polyfill crypto.randomUUID | ||
| if (!('randomUUID' in crypto)) { | ||
| Object.defineProperty(crypto, 'randomUUID', { value: uuid }); | ||
| } |
There was a problem hiding this comment.
Just to be sure. The window.crypto object is always defined, and it's just randomUUID that's missing?
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-398-polyfill-randomUUID
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When n8n is used in an insecure context,
window.cryptois an empty object, because crypto API is only available in secure contexts.This PR uses the
uuidpackage to polyfillcrypto.randomUUIDfor such cases.Related Linear tickets, Github issues, and Community forum posts
CAT-398
Fixes #12051
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)