Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OpenAI Node): Allow updating assistant files #12042

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix(OpenAI Node): Allow updating assistant files #12042

merged 4 commits into from
Dec 6, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Dec 4, 2024 •
edited by riascho
Loading

Summary

Fix issues with updating files for assistant resource

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 4, 2024
@mutdmour mutdmour changed the title fix(OpenAi Node): Allow updating assistant files fix(OpenAI Node): Allow updating assistant files Dec 4, 2024
burivuhster
burivuhster previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Dec 4, 2024 •
edited
Loading

n8n    Run #8232

Run Properties:  status check passed Passed #8232  •  git commit 30c45b8ec3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review ado-2960
Run status status check passed Passed #8232
Run duration 04m 42s
Commit git commit 30c45b8ec3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ndors/OpenAi/actions/assistant/update.operation.ts 77.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mutdmour mutdmour requested a review from burivuhster December 6, 2024 09:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 7b20f8a into master Dec 6, 2024
39 checks passed
@mutdmour mutdmour deleted the ado-2960 branch December 6, 2024 13:06
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
@janober
Copy link
Member

janober commented Dec 11, 2024

Got released with n8n@1.72.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burivuhster burivuhster burivuhster approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @burivuhster