Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Improvements to the commit modal #12031

Merged
merged 16 commits into from
Dec 6, 2024
Merged

fix(editor): Improvements to the commit modal #12031

merged 16 commits into from
Dec 6, 2024

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Dec 4, 2024 •
edited
Loading

Summary

image

  • add strong typings for source control
  • improved logic about file selection
  • sticky header and footer, (user were not able to find the commit input)
  • virtualised
  • add basic filters, by name and by status

Related Linear tickets, Github issues, and Community forum posts

PAY-2305

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.93243% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...or-ui/src/components/SourceControlPushModal.ee.vue 94.52% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@r00gm r00gm marked this pull request as ready for review December 4, 2024 12:41
@r00gm r00gm requested a review from cstuncsik December 4, 2024 12:41
@r00gm r00gm changed the title fix(editor): Pay 2305 improvements to the commit modal fix(editor): Improvements to the commit modal Dec 4, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 6, 2024

n8n    Run #8231

Run Properties:  status check passed Passed #8231  •  git commit 079e4f2ddb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-2305-improvements-to-the-commit-modal
Run status status check passed Passed #8231
Run duration 06m 53s
Commit git commit 079e4f2ddb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit 4fe1952 into master Dec 6, 2024
37 checks passed
@r00gm r00gm deleted the pay-2305-improvements-to-the-commit-modal branch December 6, 2024 11:53
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
@janober
Copy link
Member

janober commented Dec 11, 2024

Got released with n8n@1.72.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
@r00gm @riascho
fix(editor): Improvements to the commit modal (#12031)
a2246e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r00gm @janober @cstuncsik