fix(editor): Universal button snags #11974
Conversation
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
…ton-and-projects
…ton-and-projects
…ton-and-projects
| @@ -323,9 +328,21 @@ onClickOutside(createBtn as Ref<VueInstance>, () => { | |||
| @select="handleMenuSelect" | |||
| > | |||
| <N8nIconButton icon="plus" type="secondary" outline /> | |||
| <template #[`item.append.${CREATE_PROJECT_ID}`]="{ item }"> | |||
There was a problem hiding this comment.
Just spotted this
Isn't there a nicer solution?
This looks very weird, could it be just a computed?
There was a problem hiding this comment.
it's a dynamic slot and is used for thing like this when you only want your changes to affect specific elements within what's rendered,
i could create a computed inside the composable that return the same string, but it would be just moving it from one place to another
There was a problem hiding this comment.
Sure, but I think it's more readable and understandable
There was a problem hiding this comment.
you were right it looks much nicer, thank you!
|
✅ No visual regressions found. |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2272-snags-to-fix-on-new-universal-button-and-projects
|
| Run status |
|
| Run duration | 04m 31s |
| Commit |
|
| Committer | r00gm |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
pay-2272-snags-to-fix-on-new-universal-button-and-projects
branch
|
Got released with |
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)