diff --git a/cypress/e2e/20-workflow-executions.cy.ts b/cypress/e2e/20-workflow-executions.cy.ts index 94e913c787408..37036a7971d6e 100644 --- a/cypress/e2e/20-workflow-executions.cy.ts +++ b/cypress/e2e/20-workflow-executions.cy.ts @@ -16,11 +16,10 @@ describe('Current Workflow Executions', () => { it('should render executions tab correctly', () => { createMockExecutions(); cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions'); - cy.intercept('GET', '/rest/executions/active?filter=*').as('getActiveExecutions'); executionsTab.actions.switchToExecutionsTab(); - cy.wait(['@getExecutions', '@getActiveExecutions']); + cy.wait(['@getExecutions']); executionsTab.getters.executionsList().scrollTo(0, 500).wait(0); diff --git a/cypress/e2e/28-debug.cy.ts b/cypress/e2e/28-debug.cy.ts index b022ce5ac6333..9f788f0c4e6b6 100644 --- a/cypress/e2e/28-debug.cy.ts +++ b/cypress/e2e/28-debug.cy.ts @@ -19,7 +19,6 @@ describe('Debug', () => { it('should be able to debug executions', () => { cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions'); cy.intercept('GET', '/rest/executions/*').as('getExecution'); - cy.intercept('GET', '/rest/executions/active?filter=*').as('getActiveExecutions'); cy.intercept('POST', '/rest/workflows/run').as('postWorkflowRun'); cy.signin({ email: INSTANCE_OWNER.email, password: INSTANCE_OWNER.password }); @@ -41,7 +40,7 @@ describe('Debug', () => { executionsTab.actions.switchToExecutionsTab(); - cy.wait(['@getExecutions', '@getActiveExecutions']); + cy.wait(['@getExecutions']); executionsTab.getters.executionDebugButton().should('have.text', 'Debug in editor').click(); cy.url().should('include', '/debug'); diff --git a/cypress/e2e/30-editor-after-route-changes.cy.ts b/cypress/e2e/30-editor-after-route-changes.cy.ts index 733753314b5ff..727078e7352c9 100644 --- a/cypress/e2e/30-editor-after-route-changes.cy.ts +++ b/cypress/e2e/30-editor-after-route-changes.cy.ts @@ -136,10 +136,9 @@ describe('Editor actions should work', () => { it('after switching between Editor and Executions', () => { cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions'); - cy.intercept('GET', '/rest/executions/active?filter=*').as('getActiveExecutions'); executionsTab.actions.switchToExecutionsTab(); - cy.wait(['@getExecutions', '@getActiveExecutions']); + cy.wait(['@getExecutions']); cy.wait(500); executionsTab.actions.switchToEditorTab(); editWorkflowAndDeactivate(); @@ -149,7 +148,6 @@ describe('Editor actions should work', () => { it('after switching between Editor and Debug', () => { cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions'); cy.intercept('GET', '/rest/executions/*').as('getExecution'); - cy.intercept('GET', '/rest/executions/active?filter=*').as('getActiveExecutions'); cy.intercept('POST', '/rest/workflows/run').as('postWorkflowRun'); editWorkflowAndDeactivate(); @@ -157,7 +155,7 @@ describe('Editor actions should work', () => { cy.wait(['@postWorkflowRun']); executionsTab.actions.switchToExecutionsTab(); - cy.wait(['@getExecutions', '@getActiveExecutions']); + cy.wait(['@getExecutions']); executionsTab.getters.executionListItems().should('have.length', 1).first().click(); cy.wait(['@getExecution']); diff --git a/cypress/e2e/5-ndv.cy.ts b/cypress/e2e/5-ndv.cy.ts index 7ce95aba055f1..b400e1159ece1 100644 --- a/cypress/e2e/5-ndv.cy.ts +++ b/cypress/e2e/5-ndv.cy.ts @@ -679,7 +679,7 @@ describe('NDV', () => { }); }); - it('Stop listening for trigger event from NDV', () => { + it.only('Stop listening for trigger event from NDV', () => { cy.intercept('POST', '/rest/workflows/run').as('workflowRun'); workflowPage.actions.addInitialNodeToCanvas('Local File Trigger', { keepNdvOpen: true, diff --git a/cypress/e2e/7-workflow-actions.cy.ts b/cypress/e2e/7-workflow-actions.cy.ts index 04dc441c14794..794e2ee605821 100644 --- a/cypress/e2e/7-workflow-actions.cy.ts +++ b/cypress/e2e/7-workflow-actions.cy.ts @@ -111,16 +111,19 @@ describe('Workflow Actions', () => { // This happens when users click save button from workflow name input // In this case blur on the input saves the workflow and then click on the button saves it again WorkflowPage.actions.visit(); - WorkflowPage.getters.workflowNameInput().invoke('val').then((oldName) => { - WorkflowPage.getters.workflowNameInputContainer().click(); - WorkflowPage.getters.workflowNameInput().type('{selectall}'); - WorkflowPage.getters.workflowNameInput().type('Test'); - WorkflowPage.getters.saveButton().click(); - WorkflowPage.getters.workflowNameInput().should('have.value', 'Test'); - cy.visit(WorkflowPages.url); - // There should be no workflow with the old name (duplicate save) - WorkflowPages.getters.workflowCards().contains(String(oldName)).should('not.exist'); - }); + WorkflowPage.getters + .workflowNameInput() + .invoke('val') + .then((oldName) => { + WorkflowPage.getters.workflowNameInputContainer().click(); + WorkflowPage.getters.workflowNameInput().type('{selectall}'); + WorkflowPage.getters.workflowNameInput().type('Test'); + WorkflowPage.getters.saveButton().click(); + WorkflowPage.getters.workflowNameInput().should('have.value', 'Test'); + cy.visit(WorkflowPages.url); + // There should be no workflow with the old name (duplicate save) + WorkflowPages.getters.workflowCards().contains(String(oldName)).should('not.exist'); + }); }); it('should copy nodes', () => { @@ -252,7 +255,6 @@ describe('Workflow Actions', () => { it('should keep endpoint click working when switching between execution and editor tab', () => { cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions'); - cy.intercept('GET', '/rest/executions/active?filter=*').as('getActiveExecutions'); WorkflowPage.actions.addInitialNodeToCanvas(MANUAL_TRIGGER_NODE_NAME); WorkflowPage.actions.addNodeToCanvas(EDIT_FIELDS_SET_NODE_NAME); @@ -263,7 +265,7 @@ describe('Workflow Actions', () => { cy.get('body').type('{esc}'); executionsTab.actions.switchToExecutionsTab(); - cy.wait(['@getExecutions', '@getActiveExecutions']); + cy.wait(['@getExecutions']); cy.wait(500); executionsTab.actions.switchToEditorTab(); diff --git a/packages/editor-ui/src/composables/useRunWorkflow.ts b/packages/editor-ui/src/composables/useRunWorkflow.ts index 68db3ecfe7f18..9706a57729135 100644 --- a/packages/editor-ui/src/composables/useRunWorkflow.ts +++ b/packages/editor-ui/src/composables/useRunWorkflow.ts @@ -37,6 +37,7 @@ import type { useRouter } from 'vue-router'; import { isEmpty } from '@/utils/typesUtils'; import { useI18n } from '@/composables/useI18n'; import { get } from 'lodash-es'; +import { useExecutionsStore } from '@/stores/executions.store'; export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType }) { const nodeHelpers = useNodeHelpers(); @@ -48,6 +49,7 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType { @@ -384,10 +386,10 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType