Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise support #12

Open
damianobarbati opened this issue Jan 15, 2017 · 1 comment
Open

Promise support #12

damianobarbati opened this issue Jan 15, 2017 · 1 comment

Comments

@damianobarbati
Copy link

Hey, when do you plan to add promise support? Callback style is pretty aged by now and it does not allow 1) promise chaining 2) yield 3) async/await usage.
Dropping in promise support should be as simple as checking if callback was provided, otherwise return a resolving promise with the method result.

@n8io
Copy link
Owner

n8io commented Jan 19, 2017

I agree promises need to be added. Pull requests are always welcome. Honestly, I haven't kept up with the non-breaking updates to their api so there is a lot of work to be done to bring this wrapper into a more-modern architecture. Promises, async/wait, ES6 in general...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants