Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add Docs<S> which wraps the Engine<S> #18

Merged
merged 8 commits into from
Dec 6, 2024
Merged

feat!: Add Docs<S> which wraps the Engine<S> #18

merged 8 commits into from
Dec 6, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Dec 6, 2024

Description

Add Docs<S> which wraps the Engine<S>

The ProtocolHandler is now implemented only for Docs<S>.

Docs<S> has a builder that takes a Blobs<S> and Gossip<S>, but there is also a way to create a Docs directly from an Engine.

Breaking Changes

  • Engine no longer implements the ProtocolHandler trait

The ProtocolHandler is now implemented only for Blobs<S>.

Docs<S> has a builder that takes a Blobs<S> and Gossip<S>, but there is also
a way to create a Docs directly from an Engine.
@rklaehn rklaehn changed the title Add Docs<S> which wraps the Engine<S> feat!: Add Docs<S> which wraps the Engine<S> Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-docs/pr/18/docs/iroh_docs/

Last updated: 2024-12-06T17:27:24Z

src/protocol.rs Outdated Show resolved Hide resolved
src/protocol.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rklaehn rklaehn merged commit 857f0dc into main Dec 6, 2024
24 checks passed
@rklaehn rklaehn deleted the builder branch December 6, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants