Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThermoRawFileImport on MS3 fails #447

Open
robinschmid opened this issue Dec 6, 2021 · 9 comments
Open

ThermoRawFileImport on MS3 fails #447

robinschmid opened this issue Dec 6, 2021 · 9 comments
Labels
bug Something isn't working priority_high needs a fix ASAP

Comments

@robinschmid
Copy link
Member

The raw data file import generates an mzML with only the last m/z isolation step. Usually mzML has multiple precursor ions sorted by MS level. See the snap below for MS3 from .raw.
@tomas-pluskal do you want to reach out about that?

image

@tomas-pluskal
Copy link
Member

Could you upload a sample file? I'll write to them.

@robinschmid
Copy link
Member Author

Orbitrap IDX up do MS4
202112_DIMS_MS4_DDA_Orbitrap_IDX.zip

@tomas-pluskal
Copy link
Member

Have you tried running the ThermoRawFileParser on this file?
I am getting this exception:

C:\ThermoRawFileParser>ThermoRawFileParser.exe -i 202112_DIMS_MS4_DDA_Orbitrap_IDX.raw
2021-12-08 09:47:29 INFO Started parsing 202112_DIMS_MS4_DDA_Orbitrap_IDX.raw
2021-12-08 09:47:30 INFO Processing 1280 MS scans
10% 2021-12-08 09:47:31 ERROR An unexpected error occured while parsing file:202112_DIMS_MS4_DDA_Orbitrap_IDX.raw
2021-12-08 09:47:31 ERROR System.ObjectDisposedException: Cannot access a closed file.
   at System.IO.__Error.FileNotOpen()
   at System.IO.FileStream.Write(Byte[] array, Int32 offset, Int32 count)
   at System.Security.Cryptography.CryptoStream.FlushFinalBlock()
   at System.Security.Cryptography.CryptoStream.Dispose(Boolean disposing)
   at System.IO.Stream.Close()
   at ThermoRawFileParser.Writer.MzMlSpectrumWriter.Write(IRawDataPlus rawFile, Int32 firstScanNumber, Int32 lastScanNumber) in /home/niels/Documents/Development/Projects/ThermoRawFileParser/Writer/MzMlSpectrumWriter.cs:line 577
   at ThermoRawFileParser.RawFileParser.ProcessFile(ParseInput parseInput) in /home/niels/Documents/Development/Projects/ThermoRawFileParser/RawFileParser.cs:line 139
   at ThermoRawFileParser.RawFileParser.TryProcessFile(ParseInput parseInput) in /home/niels/Documents/Development/Projects/ThermoRawFileParser/RawFileParser.cs:line 62

It seems the parsing crashed after ~10% of the file. Not sure if that is also causing your problem with precursors, or if that is a different problem. Will investigate.

@tomas-pluskal
Copy link
Member

@robinschmid
Copy link
Member Author

Was fixed in the parser so we should update the parser internally

@titodamiani
Copy link
Collaborator

@robinschmid @tomas-pluskal has this been fixed? Or it's still an open issue?

@tomas-pluskal
Copy link
Member

I think we still have not updated the parser..

@SteffenHeu
Copy link
Member

@robinschmid can you comment if this is still an issue?

@SteffenHeu SteffenHeu added bug Something isn't working priority_high needs a fix ASAP labels Dec 14, 2023
@ansgarkorf
Copy link
Member

Should be fine after Tomas PR: #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority_high needs a fix ASAP
Projects
None yet
Development

No branches or pull requests

5 participants