Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is project going to support preact 10? #92

Open
Miroshni4enko opened this issue Oct 4, 2019 · 9 comments
Open

Is project going to support preact 10? #92

Miroshni4enko opened this issue Oct 4, 2019 · 9 comments

Comments

@Miroshni4enko
Copy link

No description provided.

@shelacek
Copy link

shelacek commented Oct 7, 2019

Hello,
I migrated preact-render-spy to Preact 10. You can take a look at https://github.com/shelacek/preact-render-spy. It's WIP and there are some corner cases where this fork behaves differently.

@gnarf, @mzgoddard can you please comment on the Preact 10 support?

@Miroshni4enko
Copy link
Author

Thanks!)

@nickytonline
Copy link

nickytonline commented Jan 22, 2020

First off, thanks for this project. I'm curious as well if this project will support the latest Preact? Happy to help if it gets things moving. I see that @shelacek forked and has it working with v. 10. Would you consider putting up a PR for it @shelacek?

@shelacek
Copy link

shelacek commented Apr 9, 2020

I apologize for the late reaction.

I'd like to make a PR, but at the moment I'm not sure if it would ever be accepted. However, I quite like preact-render-spy for smaller projects over a much bigger enzyme. If there is no reaction from maintainers, maybe we can join forces elsewhere. I've also noticed some meaningful commits from @soerenvullriede2101.

@soerenvullriede2101
Copy link

We used preact-render-spy for a small project, with the update to v10 we wanted to use Fragments, so we updated the fork of @shelacek and fixed some tests. But there are still a bunch of failing tests, especially the https://github.com/mzgoddard/preact-render-spy/blob/master/src/shared-render.test.js . It seems like the contains function etc. does not work anymore. I could create a PR for the stuff we did, but this project seems kinda abandoned.

@thisconnect
Copy link

Any update on this?

@Xan0C
Copy link

Xan0C commented Aug 22, 2020

I guess its dead, would recommend to switch to something else if possible. I tried to fix a few things to make it kind of work again, but it feels kinda hacky.
You can find it here: https://github.com/Xan0C/preact-render-spy

PS: Im @soerenvullriede2101 this is my private account

@thisconnect
Copy link

thanks for the info, FYI: I checked out a new prect-cli typescript project and it is using enzyme now.

@nickytonline
Copy link

We migrated towards preact-testing-library, forem/forem#8224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants