Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: BrokerPort should be configurable #226

Closed
zyfdegh opened this issue Apr 12, 2018 · 4 comments
Closed

Refactor: BrokerPort should be configurable #226

zyfdegh opened this issue Apr 12, 2018 · 4 comments

Comments

@zyfdegh
Copy link
Contributor

zyfdegh commented Apr 12, 2018

In communication/nats/discovery/config.go, broker port is currently hard-coding as

BrokerPort             = 4222

It impossible to change if broker (NATS) use a different port.

@Waldz
Copy link
Member

Waldz commented Apr 12, 2018

Good idea, we could implement argument --broker-port save way as argument mysterium_server --broker-address=127.0.0.1 is implemented.

Feel free to contribute to our repo

@zyfdegh
Copy link
Contributor Author

zyfdegh commented Apr 12, 2018

@Waldz Since -broker-address is address of broker, it's supposed to contain host and port. We can simply append the port in existing address. So I will put a PR later to parse the address and update the documents on how to use the flag and .env.

@Waldz Waldz added this to the VPN external providers milestone Apr 12, 2018
@stale
Copy link

stale bot commented Oct 2, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 2, 2018
@Waldz
Copy link
Member

Waldz commented Oct 23, 2018

Service provider how can control broker-address - where his communication channel is.

myst help

--broker-address value           Address (IP or domain name) of message broker (default: "testnet-broker.mysterium.network")

I suggest to have contact.broker-address and contact.broker-port to have more control where communication channel is established

@stale stale bot removed the stale label Oct 23, 2018
@Waldz Waldz removed this from the VPN external providers milestone Oct 23, 2018
@Waldz Waldz added the good first issue Good for newcomers label Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants