Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic image url #1783

Merged
merged 2 commits into from
Mar 29, 2023
Merged

feat: dynamic image url #1783

merged 2 commits into from
Mar 29, 2023

Conversation

nekaartajaya
Copy link
Contributor

Describe your changes

Issue ticket number / link

https://blocksphere2020.atlassian.net/browse/MYR-2984

@nekaartajaya nekaartajaya requested a review from irmannmal March 27, 2023 15:16
@nekaartajaya nekaartajaya requested a review from a team as a code owner March 27, 2023 15:16
@irmannmal irmannmal requested a review from a team as a code owner March 27, 2023 21:46
@irmannmal
Copy link
Member

please check on this file src/helpers/image.ts @nekaartajaya
need to remove:

@irmannmal irmannmal merged commit 8794df3 into myriadsocial:main Mar 29, 2023
@myriaddevops myriaddevops mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irmannmal irmannmal irmannmal approved these changes

@alvin371 alvin371 Awaiting requested review from alvin371 alvin371 is a code owner automatically assigned from myriadsocial/frontend

@ciniiia ciniiia Awaiting requested review from ciniiia ciniiia is a code owner automatically assigned from myriadsocial/frontend

@myriaddevops myriaddevops Awaiting requested review from myriaddevops myriaddevops is a code owner automatically assigned from myriadsocial/frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekaartajaya @irmannmal