fix: correct 1.1.2 upgrade #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{$module::MODULE_NAME} in heredoc crashes. Tested it in PHP 7.3.31 haven't tested other PHP versions but using your syntax it's crashing.
That's why i created the var $moduleName. Tested various other ways to use the $module::MODULE_NAME in the heredoc but all fail.
Preg_match and strpos was on an array $record instead of string $record->name
EdieLemoine
approved these changes
Oct 26, 2021
|
Looks good, thank you! We'll test this, then it can be merged. |
RichardPerdaan
approved these changes
Oct 26, 2021
EdieLemoine
pushed a commit
that referenced
this pull request
Nov 8, 2021
- fix syntax error - fix carrier configuration not being migrated correctly for DPD and PostNL in MyParcel BE
RichardPerdaan
pushed a commit
that referenced
this pull request
Nov 11, 2021
- fix syntax error - fix carrier configuration not being migrated correctly for DPD and PostNL in MyParcel BE
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
## [1.3.0](v1.2.0...v1.3.0) (2021-11-11) ### ✨ New Features * add track trace in default prestashop field ([a274f3f](a274f3f)) * export region field ([#58](#58)) ([0950fae](0950fae)) ### 🐛 Bug Fixes * add second address line to first address line for delivery options ([#61](#61)) ([0ed533b](0ed533b)) * allow insurance options only for package type package ([#62](#62)) ([af7497c](af7497c)) * correct 1.1.2 upgrade ([#52](#52)) ([4c33988](4c33988)) * dpz weight classes automatically selected and retained ([#53](#53)) ([e398582](e398582)) * fix delivery options in frontend not loading fully sometimes ([#54](#54)) ([2ef3009](2ef3009)) * fix delivery options not being persisted in ps 1.7.8.0 ([#57](#57)) ([d625781](d625781)), closes [#49](#49) * fix large format and return not being exported ([#64](#64)) ([17c1e4d](17c1e4d)) * fix track trace emails not being sent ([#66](#66)) ([dcebc16](dcebc16)) * fix user agent not being sent correctly ([#65](#65)) ([801f00b](801f00b)) * fix user agents not being sent ([607adc9](607adc9)) * make possible to export without insurance from order detail page ([2610e67](2610e67)) * migration will be to version 1.3.0 ([199a078](199a078)) * remove hard coded carrier from email templates and improve language ([23595c9](23595c9)) * set nextDeliveryDate when deliveryOptions are empty ([#47](#47)) ([20ab7a7](20ab7a7)) * shipment status order for digital stamp ([20dbf91](20dbf91)) * update orderlabel status during export ([03a7690](03a7690))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{$module::MODULE_NAME} in heredoc crashes. Tested it in PHP 7.3.31 haven't tested other PHP versions but using your syntax it's crashing.
That's why i created the var $moduleName. Tested various other ways to use the $module::MODULE_NAME in the heredoc but all fail.
Preg_match and strpos was on an array $record instead of string $record->name