Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audits): prevent type error for id in model #291

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

joerivanveen
Copy link
Contributor

INT-769

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.30%. Comparing base (0c3d1dd) to head (5e06e87).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Entity/MyparcelnlAudit.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #291      +/-   ##
============================================
- Coverage     52.52%   49.30%   -3.23%     
+ Complexity      693      602      -91     
============================================
  Files           152      151       -1     
  Lines          4232     3896     -336     
  Branches         55       55              
============================================
- Hits           2223     1921     -302     
+ Misses         1954     1920      -34     
  Partials         55       55              
Flag Coverage Δ
backend 76.96% <0.00%> (-1.54%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 12, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 5e06e87
Logs https://github.com/myparcelnl/prestashop/actions/runs/12296692967
Download https://github.com/myparcelnl/prestashop/suites/31983369584/artifacts/2311558183

@joerivanveen joerivanveen marked this pull request as ready for review December 12, 2024 12:49
@joerivanveen joerivanveen requested a review from a team as a code owner December 12, 2024 12:49
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 18, 2024
@joerivanveen joerivanveen merged commit 24c1072 into main Dec 19, 2024
10 of 12 checks passed
@joerivanveen joerivanveen deleted the fix/audits/prevent-type-error-for-id-in-model branch December 19, 2024 10:36
myparcel-bot bot added a commit that referenced this pull request Dec 19, 2024
## [4.2.2](v4.2.1...v4.2.2) (2024-12-19)

### 🐛 Bug Fixes

* **audits:** prevent type error for id in model ([#291](#291)) ([24c1072](24c1072))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 19, 2024

🎉 This PR is included in version 4.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants