Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(delivery-options): fix not showing after switching shipping method #113

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jan 13, 2022

  • delivery options would not reappear after being rendered, switching to a shipping method that does not support delivery options, and then switching back to one that does

Resolves #105

Bij het switchen naar een shipping method zonder DO verbergt de DO zichzelf, waardoor de html content verdwijnt. Dan bestaat form.myparcel-delivery-options ineens niet meer en werken de oude codes niet...

views/js/frontend.js Outdated Show resolved Hide resolved
- delivery options would not reappear after being rendered, switching to a shipping method that does not support delivery options, and then switching back to one that does

Resolves #105
@EdieLemoine EdieLemoine force-pushed the fix-delivery-options-not-showing branch from 7a2526d to 0452a2f Compare January 14, 2022 08:24
@EdieLemoine EdieLemoine merged commit 45590a9 into main Jan 19, 2022
@EdieLemoine EdieLemoine deleted the fix-delivery-options-not-showing branch January 19, 2022 10:53
github-actions bot pushed a commit that referenced this pull request Mar 22, 2022
## [1.5.0](v1.4.1...v1.5.0) (2022-03-22)

### 🐛 Bug Fixes

* **delivery-options:** fix not showing after switching shipping method ([#113](#113)) ([45590a9](45590a9)), closes [#105](#105)
* **delivery-options:** no pickup when not chosen ([#118](#118)) ([ac86052](ac86052))
* fix error retrieving delivery settings ([#109](#109)) ([a28c116](a28c116))

### ✨ New Features

* improve entire admin backoffice ([#104](#104)) ([167a1d3](167a1d3))
@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Myparcel still acts weirdly (in native checkout)
3 participants