Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't output false for shipment options that are disabled #247

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Sep 27, 2024

INT-656

@EdieLemoine EdieLemoine requested a review from a team as a code owner September 27, 2024 11:01
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit f4d1e54
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/66f6a1c714f648000828f674
😎 Deploy Preview https://deploy-preview-247--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 27, 2024

Bundle Report

Changes will increase total bundle size by 248 bytes (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 151.83kB 129 bytes (0.09%) ⬆️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 117.06kB 119 bytes (0.1%) ⬆️

@myparcel-bot myparcel-bot bot force-pushed the fix/shipment-options-output branch from b517cdd to f4d1e54 Compare September 27, 2024 12:15
@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 27, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 1cba349 Oct 2, 2024
13 checks passed
@EdieLemoine EdieLemoine deleted the fix/shipment-options-output branch October 2, 2024 12:29
myparcel-bot bot added a commit that referenced this pull request Oct 2, 2024
## [@myparcel/delivery-options-v6.2.4](v6.2.3...v6.2.4) (2024-10-02)

### 🐛 Bug Fixes

* don't output false for shipment options that are disabled ([#247](#247)) ([1cba349](1cba349))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Oct 2, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants