modify delete_bitmap_action

Author: mymeiyi

be/src/http/action/delete_bitmap_action.cpp

@@ -67,7 +67,7 @@ DeleteBitmapAction::DeleteBitmapAction(DeleteBitmapActionType ctype, ExecEnv* ex
           _engine(engine),
           _delete_bitmap_action_type(ctype) {}
 
-static Status _check_param(HttpRequest* req, uint64_t* tablet_id) {
+static Status _check_param(HttpRequest* req, uint64_t* tablet_id, bool* verbose) {
     const auto& req_tablet_id = req->param(TABLET_ID_KEY);
     if (req_tablet_id.empty()) {
         return Status::InternalError("tablet id is empty!");
@@ -77,17 +77,18 @@ static Status _check_param(HttpRequest* req, uint64_t* tablet_id) {
     } catch (const std::exception& e) {
         return Status::InternalError("convert tablet_id failed, {}", e.what());
     }
+    if (*tablet_id == 0) {
+        return Status::InternalError("check param failed: invalid tablet_id");
+    }
+    *verbose = iequal(req->param("verbose"), "true");
     return Status::OK();
 }
 
 Status DeleteBitmapAction::_handle_show_local_delete_bitmap_count(HttpRequest* req,
                                                                   std::string* json_result) {
     uint64_t tablet_id = 0;
-    // check & retrieve tablet_id from req if it contains
-    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id), "check param failed");
-    if (tablet_id == 0) {
-        return Status::InternalError("check param failed: missing tablet_id");
-    }
+    bool verbose = false;
+    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, &verbose), "check param failed");
 
     BaseTabletSPtr tablet = nullptr;
     if (config::is_cloud_mode()) {
@@ -98,17 +99,33 @@ Status DeleteBitmapAction::_handle_show_local_delete_bitmap_count(HttpRequest* r
     if (tablet == nullptr) {
         return Status::NotFound("Tablet not found. tablet_id={}", tablet_id);
     }
-    auto count = tablet->tablet_meta()->delete_bitmap().get_delete_bitmap_count();
-    auto cardinality = tablet->tablet_meta()->delete_bitmap().cardinality();
-    auto size = tablet->tablet_meta()->delete_bitmap().get_size();
-    LOG(INFO) << "show_local_delete_bitmap_count,tablet_id=" << tablet_id << ",count=" << count
-              << ",cardinality=" << cardinality << ",size=" << size;
-
+    auto dm = tablet->tablet_meta()->delete_bitmap().snapshot();
+    auto count = dm.get_delete_bitmap_count();
+    auto cardinality = dm.cardinality();
+    auto size = dm.get_size();
+    LOG(INFO) << "show_local_delete_bitmap_count for tablet_id=" << tablet_id << ", count=" << count
+              << ", cardinality=" << cardinality << ", size=" << size;
     rapidjson::Document root;
     root.SetObject();
     root.AddMember("delete_bitmap_count", count, root.GetAllocator());
     root.AddMember("cardinality", cardinality, root.GetAllocator());
     root.AddMember("size", size, root.GetAllocator());
+    if (verbose) {
+        rapidjson::Document dm_arr;
+        dm_arr.SetArray();
+        for (auto& [id, bitmap] : dm.delete_bitmap) {
+            auto& [rowset_id, segment_id, version] = id;
+            std::stringstream ss;
+            ss << "rowset: " << rowset_id.to_string() << ", segment: " << segment_id
+               << ", version: " << version << ". cardinality: " << bitmap.cardinality()
+               << ", size: " << bitmap.getSizeInBytes();
+            std::string str = ss.str();
+            rapidjson::Value value;
+            value.SetString(str.c_str(), cast_set<uint32_t>(str.length()), dm_arr.GetAllocator());
+            dm_arr.PushBack(value, dm_arr.GetAllocator());
+        }
+        root.AddMember("delete_bitmap", dm_arr, root.GetAllocator());
+    }
 
     // to json string
     rapidjson::StringBuffer strbuf;
@@ -122,11 +139,9 @@ Status DeleteBitmapAction::_handle_show_local_delete_bitmap_count(HttpRequest* r
 Status DeleteBitmapAction::_handle_show_ms_delete_bitmap_count(HttpRequest* req,
                                                                std::string* json_result) {
     uint64_t tablet_id = 0;
-    // check & retrieve tablet_id from req if it contains
-    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id), "check param failed");
-    if (tablet_id == 0) {
-        return Status::InternalError("check param failed: missing tablet_id");
-    }
+    bool verbose = false;
+    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, &verbose), "check param failed");
+
     TabletMetaSharedPtr tablet_meta;
     auto st = _engine.to_cloud().meta_mgr().get_tablet_meta(tablet_id, &tablet_meta);
     if (!st.ok()) {