MapUtil#computeIfAbsent Object repeated creation

[TAKETODAY]

mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java

Line 35 in acde70c

return map.computeIfAbsent(key, mappingFunction::apply);

Present version

  public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
    V value = map.get(key);
    if (value != null) {
      return value;
    }
    return map.computeIfAbsent(key, mappingFunction::apply); // Object repeated creation
  }

Fix

  public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
    V value = map.get(key);
    if (value != null) {
      return value;
    }
    return map.computeIfAbsent(key, mappingFunction); // Pass parameters directly
  }

[TAKETODAY]

Did I understand it wrong? ? ?

[harawata]

Oh, you are right.
Would you care to send us a pull request?
If you are busy, that is okay. I'll fix it later.

[TAKETODAY]

Yes

[harawata]

PR merged. Thank you!