Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge policy #41

Open
merlosy opened this issue Jul 13, 2018 · 4 comments
Open

Merge policy #41

merlosy opened this issue Jul 13, 2018 · 4 comments

Comments

@merlosy
Copy link

merlosy commented Jul 13, 2018

Hi,
I'd like to use this but the merge policy is not what i'd need.
Could it be possible to customize the merge "policy"? Instead of adding up the values, i'd like to pick the suite with the best result when the same file is tested.
This could be an argument when running the script: policy=sum or policy=best

What do you think?

@mweibel
Copy link
Owner

mweibel commented Jul 13, 2018

That's probably requiring a bigger refactoring (but that might be required anyway for not repeating the code all the time if we'd want to implement parsing of more sections).
I don't really have time to work on this, but if you have I'd be happy to review. Would be nice to have smaller PRs in order to ensure fast reviews though :)

@merlosy
Copy link
Author

merlosy commented Jul 13, 2018

Just spent the day doing this:
https://gist.github.com/merlosy/55b7f974ca2116203c6cee4e6676068f
This seems to do the job.. The implementation is a bit different, no dependencies, es6...

@PieterLeRoux177
Copy link

@merlosy Are you going to create a pull request for the fix?
I need exactly what you did here.

@merlosy
Copy link
Author

merlosy commented Jul 25, 2018

@PieterLeRoux177 What i did is a full rewrite.. Not really eligible for a PR then. As @mweibel mentioned, it would be a lot of work to review, especially since I didn't implement any test. I'm not even sure all the features provided in this repo are in my solution.
Anyway, if you want to use my solution, you can simply copy/paste from the gist (link above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants