Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable/log stacktrace #76

Closed
robmessick opened this issue Mar 15, 2016 · 4 comments
Closed

Add setting to disable/log stacktrace #76

robmessick opened this issue Mar 15, 2016 · 4 comments

Comments

@robmessick
Copy link

robmessick commented Mar 15, 2016

I would like an option to suppress stacktraces from being returned by the watchman views.

Add the following new settings:

WATCHMAN_RENDER_STACKTRACE = (True|False) - If enabled, watchman will return the stacktrace in the json and dashboard views.

WATCHMAN_LOG_STACKTRACE = (True|False) - If enabled, watchman will log stacktraces to the django logger.

@mwarkentin
Copy link
Owner

Hey @robmessick, thanks for the suggestion! This sounds like an interesting idea - I'm curious on what your use-case is for this?

Is this something you might be able to take a look at adding?

@robmessick
Copy link
Author

I'm concerned about data leakage through the stack trace. We currently have our healthtest restricted to an internal network but I'd rather have the stack traces only available to our log indexer and end users be able to check the health of service. I'm happy to submit a PR as I find django-watchman solves my needs much better than django-health-check.

@mwarkentin
Copy link
Owner

Makes sense. Will need to see the code for the logger setting to get a better idea on how that will work.

Please default the render setting to True so that default functionality remains the same.

@mwarkentin
Copy link
Owner

@robmessick this has been open for quite a while, and we recently added a "bare" endpoint in #114 - not quite the same as what you described here, but maybe it would fit for you. I'm going to close this, but feel free to reopen if the other changes don't cover your use case, or I'd be happy to look at a PR implementing your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants