Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency correction, midi noteon/noteoff order issue #779

Closed
spamatica opened this issue Mar 15, 2020 · 6 comments
Closed

Latency correction, midi noteon/noteoff order issue #779

spamatica opened this issue Mar 15, 2020 · 6 comments
Labels

Comments

@spamatica
Copy link
Member

During some collaboration with MusE user oscillator I disovered the reason for an issue I noted earlier on.
Basically, when Latency correction is enabled midi notes that are player back to back will (sometimes it seems) not always sound correctly.
A melodyline where the same note was played over an over the new note starting on the same beat as the first one stopped will sometimes only make a very short sound like it is playing but then immediately silenced.
So my thought was that the noteoff might not be sorted correctly so it is played after the noteon.
An additional little discovery is that it seems to work correctly when I use RtAudio as backend instead of jack. No idea if that makes any sense.

Anyway, I know there are some issues with Latency correction, maybe this is related.

@terminator356
Copy link
Member

Going over some older issues, found this.

Observed! Wow, sorry about that, investigating...
The notes appear to require a minimum 18 ticks separation to sound.

@terminator356
Copy link
Member

Fixed in master now. Tested OK with/without latency correction, and with Jack and Rt Pulse.
Sad that it's been like that for about two years ever since my latency code, and now in version 4.
Ugh, I missed that code section.

@spamatica
Copy link
Member Author

Alright, cool. No worries, I'm sure we would have had more complaints if more people were hit.
But I guess it's getting time to make the 4.0.1 release :)

@terminator356
Copy link
Member

Lemme get that wave left-border resizing thing done before considering release.

@github-actions
Copy link

This issue is stale because it has been inactive for two years. Remove Stale label or write a comment, otherwise it will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 13, 2023
@terminator356
Copy link
Member

I guess I fixed this one. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants