Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot always duplicate events in the drum editor #1003

Closed
spamatica opened this issue May 19, 2021 · 2 comments
Closed

Cannot always duplicate events in the drum editor #1003

spamatica opened this issue May 19, 2021 · 2 comments

Comments

@spamatica
Copy link
Member

I have seen this before but haven't really been sure how to reproduce it. Not entirely sure now either, but more sure :)

Basically, while in the drum editor and there is a drum note selected. Ctrl+click on it and drag to make a copy. I usually do this to quickly make repetitions (having lots of notes selected).
The copy is created where the mouse is when you release the button. Unless you release it on the same tick as the original note, then it just vanishes. There seems to be more cases where it just vanishes but this one seems to be easily repeatable.

Using AppImage 4.0

Figured this out while I was making instruction videos so if it is unclear I can upload video evidence :D

@kybos
Copy link
Contributor

kybos commented May 21, 2021

It always vanishes when there is already at least one other event on the same target tick. I would even say that the result is also broken in all other cases when the copy is seemingly working.

Anyway, it should be fixed now. Pretty tough debugging all this undo and operations code...

@kybos kybos closed this as completed in 66b1f2d May 21, 2021
@spamatica
Copy link
Member Author

oh, wow, awesome, was not expecting that \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants