Missing Arm64 Mac (M1 apple silicon) prebuilt

[ouya99]

I did the build on arm64 and could upload "node-datachannel-v0.0.22-node-v88-darwin-arm64.tar.gz"
Would you integrate it please? It would solve a dependancy issue for me . Thank you

[murat-dogan]

Hi,

I don't have any experience on Mac.
Could you please guide me or create a pull request?

I am using github actions to build prebuilt binaries. You can check it here;
https://github.com/murat-dogan/node-datachannel/blob/master/.github/workflows/build.yml

I already added node v15 to build list.

[ouya99]

here you go : #29

do not know where you store your prebuilds, i put it in a folder /prebuilds

[porsager]

I think this is better solved with a fork and different npm package provided by @ouya99 until github actions can support M1.

It's not possible for anyone to know what the uploaded binary contains if done this way.

[murat-dogan]

We have to find a way to create prebuilt binaries with github actions.
I don't create these binaries locally, and also git project does not have these binaries as files.

If we don't have a way to do like that, then @porsager is right.

[ouya99]

@murat-dogan how do you create your prebuilds?

[porsager]

Github Actions don't support M1 yet, and it doesn't seem like it's anything that's happening soon.

It might be sooner using self hosted runners, but that'd require someone sponsoring that.

[murat-dogan]

I am creating prebuilds with github actions.

https://github.com/features/actions
https://github.com/murat-dogan/node-datachannel/blob/master/.github/workflows/build.yml

[ouya99]

by setting
OPENSSL_ROOT_DIR: /usr/local/opt/openssl
OPENSSL_LIBRARIES: /usr/local/opt/openssl/lib
and moving my OPENSSL installation to to this location (given by your build file)

I managed to build it automatically on my mac. Sorry did miss that you actually do not provide any prebuild and its built locally which works fine.

[Arrognz]

I can confirm the above comment by @ouya99. Allthough I did not move any openssl directory.

Using node 16+ on macos all I did was:

brew install cmake

Then added this in my .zshrc

export OPENSSL_ROOT_DIR="/opt/homebrew/opt/openssl@1.1"
export OPENSSL_LIBRARIES="/opt/homebrew/opt/openssl@1.1/lib"

And ran yarn add @geckos.io/server which uses node-datachannel as a dependency.

It built and I'll update this comment when I actually end up testing it at runtime.