Add missing variations of sha2 #234
Conversation
There was a problem hiding this comment.
I'd like to wait from an approval from @rvagg before this gets merged.
I don't know if sha2-384 is widely used so that it should be in the 1 byte range (we got stricter about putting things in the 1 byte range, so looking into existing hashes there isn't really meaningful). Though I also don't see a point of blocking it if there's consensus that it is good idea.
|
I will absolutely fight about it, forever. As I have said repeatedly (repeatedly, repeatedly), but will say yet one more time: it is the only hash that is in the standard libraries we especially care about, and is also some amount of strong against length-extension attacks. I will use it and I will recommend its use constantly based on these factors. |
Corresponds to multiformats/multicodec#234 . Add these also to the automatically registered set, as we do for all the other hash functions that are readily available in the golang standard library.
Per discussion in #205 ,
and further discussion of the numbers,
in #206 .
Most of the variants are shifted into larger number ranges.