fix!: Rename webrtc to webrtc-direct and webrtc-w3c to webrtc #314
Conversation
We have decided to rename `webrtc-w3c` to `webrtc-private-to-private`. See rational in multiformats/multiaddr#150. No software has been released using `webrtc-w3c`, thus renaming is not a breaking change. Ignoring the automated `multiaddr` `v11.5.0` release. See also multiformats#309 that introduced `webrtc-w3c`.
@achingbrain is the assumption correct that this does not pose any issues even though there has been an automated release,namely |
|
Friendly ping @achingbrain, @MarcoPolo and @marten-seemann. |
achingbrain
changed the title
|
This is a breaking change so it should go out as such, but the impact should be minimal, just a lot of dependabot PRs to merge. I will merged this once the upstream change has gone in. |
|
Are we actually using this anywhere? Why is it a breaking change? |
|
It's breaking because methods that previously accepted |
|
Yes, it's technically a breaking change. I see that. Is there anything that is using this that will be affected? |
|
I cannot say yes or no with 100% certainty, so it's generally better to err on the side of caution. |
There was a problem hiding this comment.
In https://github.com/multiformats/multiaddr/pull/152/files we decided that the browser-to-server version would be called webrtc-direct and the browser-to-browser version would just be webrtc
achingbrain
changed the title
achingbrain
changed the title
## [12.0.0](v11.6.1...v12.0.0) (2023-03-17) ### ⚠ BREAKING CHANGES * webrtc has been renamed webrtc-direct and webrtc-w3c has been renamed webrtc ### Bug Fixes * Rename webrtc to webrtc-direct and webrtc-w3c to webrtc ([#314](#314)) ([fc33ac8](fc33ac8))
We have decided to rename
webrtc-w3ctowebrtc-private-to-private. See rational in multiformats/multiaddr#150.No software has been released using
webrtc-w3c, thus renaming is not a breaking change. Ignoring the automatedmultiaddrv11.5.0release.See also #309 that introduced
webrtc-w3c.