This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
fix: update to aegir 31 and others deps #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for creating this PR. The latest update to multicodec breaks PeerId and a few other dependencies due to https://github.com/multiformats/js-cid/blob/master/package.json#L44 |
vmx
reviewed
Mar 2, 2021
src/index.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const mh = require('multihashes') | |||
| const multibase = require('multibase') | |||
| const multicodec = require('multicodec') | |||
| const { baseTable: codecs } = require('multicodec/src/base-table.js') | |||
| const { baseTable: codecs } = require('multicodec/src/generated-table') | |||
There was a problem hiding this comment.
We should stop using non-public APIs. We broke the world once, I don't want it to break it again.
If there is no code to name mapping in js-multicodec, we should add it properly to the public API. I can have a look later this week.
There was a problem hiding this comment.
Cids exports code to name?
There was a problem hiding this comment.
AFAICT it only changed the file name nothing else
vmx
approved these changes
Mar 2, 2021
src/index.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const mh = require('multihashes') | |||
| const multibase = require('multibase') | |||
| const multicodec = require('multicodec') | |||
| const { baseTable: codecs } = require('multicodec/src/base-table.js') | |||
| const { nameToCode: codecs } = require('multicodec') | |||
There was a problem hiding this comment.
Having multicodec imported twice is a bit strange, but I guess we want to move fast.
vmx
approved these changes
Mar 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.