fix: proto value unmarshal strings as utf8 string #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we decode string as it is, even if string in FIT protocol should be a valid utf8 string, there is no guarantee that we got a valid utf8 string when the FIT file is not properly encoded. Now, we will ensure that every character in the string is a valid utf8 character, any invalid character will be replaced with
utf8.RuneError
('\uFFFD'
/�
).Additional changes:
UnmarshalValue
loop on slice value, this change will reduce bound check.