fix: decoder handle compressed timestamp for unknown field #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 3615 3618 +3
=========================================
+ Hits 3615 3618 +3 ☔ View full report in Codecov by Sentry. |
muktihari
deleted the
fix/decoder-handle-compressed-timestamp-unknown-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering compressed timestamp message but the message is unknown (it could be manufacturer specific message), the field become unknown as well, in such cases, we must assign the
BaseTypeandTypetouint32so that the resulting decoded FIT can be encoded as per original instead of returning error in encoder since theBaseTypewas set to default value:Enum.