fix: decoder integer divide by zero on invalid basetype #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving bad encoded FIT file such as this bytes stream
[]byte("\x0e\x10^\x06\x17\b\x00\x00.FIT\xe3\xbb@0000\x060000000000000000000")
, It has fieldDef with invalid BaseType causing our decoder to panic when doing this operationfieldDef.Size%fieldDef.BaseType.Size()
since Size will return 0. To avoid this, let's make invalid size to be 255 just like all invalid values is the max size of the types. Any value modulo by 255 is always the value itself and any value divided by 255 will always zero.