Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Support columns reorder on mobile #1235

Closed
ecl1ps opened this issue Mar 15, 2021 · 3 comments
Closed

[DataGridPro] Support columns reorder on mobile #1235

ecl1ps opened this issue Mar 15, 2021 · 3 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@ecl1ps
Copy link

ecl1ps commented Mar 15, 2021

Hi,

It seems columns can't be reordered (dragged) on mobile devices (with touch events). Or at least I couldn't find a way how to do it. Resizing works fine.

Specifically tested on Chromium-based browsers for android. It can be also replicated in desktop version of Chrome and Firefox in mobile emulation mode.

Tried on oficial example https://material-ui.com/components/data-grid/columns/#column-reorder.

Thanks for fixing it up!

@oliviertassinari
Copy link
Member

@ecl1ps From what I recall from our work on this feature in #165, we ignored mobile. I wonder if the UX on mobile wouldn't be better solved by #839.

Could you expand a bit on why you need this support on mobile? It would help!

@ecl1ps
Copy link
Author

ecl1ps commented Mar 17, 2021

Thank you for response.

Honestly it seemed as na obvious bug as I couldn't found any mention of it not working on mobile in the docs. And also that other similar functionality (at least from the UX point of view) column resize si working on mobile just fine.

I can image using drag&drop to reorder columns on tablets without problems. On mobiles it would be more cumbersome.

At this moment this not an overly important feature for us. We are planning to create a standalone component (similar to #839) to configure columns and their order (#820 would be great to make it easier).

So maybe at least mention it in docs? Thanks!

@oliviertassinari oliviertassinari changed the title [XGrid] Unable to reorder columns on mobile [XGrid] Support columns reorder on mobile Mar 17, 2021
@oliviertassinari oliviertassinari added the new feature New feature or request label Mar 17, 2021
@oliviertassinari oliviertassinari changed the title [XGrid] Support columns reorder on mobile [DataGridPro] Support columns reorder on mobile Aug 30, 2021
@oliviertassinari oliviertassinari added the plan: Pro Impact at least one Pro user label Dec 5, 2021
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 29, 2022
@cherniavskii
Copy link
Member

cherniavskii commented Jul 3, 2023

Duplicate of #9330

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed new feature New feature or request plan: Pro Impact at least one Pro user labels Jul 3, 2023
@cherniavskii cherniavskii marked this as a duplicate of #9330 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants