[material-ui][Rating] Deprecate *Props and complete slots, slotProps
#45295
Conversation
Netlify deploy preview
Rating: parsed: +3.03% , gzip: +2.73% Bundle size reportDetails of bundle changes (Toolpad) |
|
@harry-whorlow Thanks for your contribution. I was working on this before I went on holiday last week, so let me take over this PR. Note, the |
|
@siriwatknp ah I see, sure thing take it away... 🤟 Out of curiosity, was the reason the pnpm proptypes not updating was because I needed to extend |
There was a problem hiding this comment.
👍 Thanks for your contribution!
I'll let @DiegoAndai do the final review.
zannager
added
the
component: rating
siriwatknp
changed the title
slots, slotProps
siriwatknp
added
the
needs cherry-pick
There was a problem hiding this comment.
Hey @harry-whorlow, looks good. We need to add this to the deprecated APIs guide: https://github.com/mui/material-ui/blob/master/docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
| { | ||
| // TODO v6: remove this class as it duplicates with the global state class Mui-readOnly | ||
| 'MuiRating-readOnly': readOnly, | ||
| }, |
There was a problem hiding this comment.
I agree with removing this, but we should add it to the upgrade guide: https://github.com/mui/material-ui/blob/master/docs/data/material/migration/upgrade-to-v7/upgrade-to-v7.md
harry-whorlow
force-pushed
the
depricate-rating-component
branch
from
1368bef to
bde43b0
Compare
|
@DiegoAndai, thank's but @siriwatknp deserves the credit on this one! I've rebased master and updated the migration to note the removal of I'll add to the migration api docs in the morning. |
|
Cherry-pick PRs will be created targeting branches: v6.x |
part of #41281
This PR adds slot the slot prop to rating, whilst deprecating components.
props.iconContainerComponent -> slot.iconContainer
[/] I have followed (at least) the PR section of the contributing guide.