Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add overriding-component-structure doc to Material UI #45186

Merged
merged 16 commits into from
Feb 26, 2025
Merged

[docs] Add overriding-component-structure doc to Material UI #45186

merged 16 commits into from
Feb 26, 2025

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 3, 2025 •
edited
Loading

closes #41281

This PR will be merged once the rest of the tasks in #41281 are done. Open this early to give @mapache-salvaje time to review.

@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Feb 3, 2025
@mui-bot
Copy link

mui-bot commented Feb 3, 2025 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c620de5

@siriwatknp siriwatknp mentioned this pull request Feb 3, 2025
Closed
38 tasks
@siriwatknp
Update docs/data/material/customization/overriding-component-structur…
c900458 
…e/overriding-component-structure.md

Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
ZeeshanTamboli
ZeeshanTamboli reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a section explaining why slots and slotProps are better than the deprecated *Component and *Props props? The advantage isn’t clear to me atleast beyond reducing multiple *Component and *Props props to just two (slots and slotProps).

@siriwatknp
Copy link
Member Author

Should we add a section explaining why slots and slotProps are better than the deprecated *Component and *Props props? The advantage isn’t clear to me atleast beyond reducing multiple *Component and *Props props to just two (slots and slotProps).

I added a section about the history of the pattern. Do you think it's clearer for the readers?

@ZeeshanTamboli
Copy link
Member

Should we add a section explaining why slots and slotProps are better than the deprecated *Component and *Props props? The advantage isn’t clear to me atleast beyond reducing multiple *Component and *Props props to just two (slots and slotProps).

I added a section about the history of the pattern. Do you think it's clearer for the readers?

Yes 👍

@siriwatknp
Copy link
Member Author

@mapache-salvaje Would you mind do a final check on this?

@siriwatknp siriwatknp added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 20, 2025
mapache-salvaje
mapache-salvaje reviewed Feb 20, 2025
View reviewed changes
@DiegoAndai DiegoAndai mentioned this pull request Feb 21, 2025
Open
3 tasks
siriwatknp and others added 3 commits February 22, 2025 06:51
@siriwatknp @mapache-salvaje
Apply suggestions from code review
7bfaa6d 
Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@siriwatknp
apply suggestion
ee4250a
@siriwatknp
Merge branch 'master' of https://github.com/mui/material-ui into docs…
631ab69 
…/mui-override-component
@siriwatknp siriwatknp force-pushed the docs/mui-override-component branch from 1a2da70 to 631ab69 Compare February 24, 2025 01:51
mapache-salvaje
mapache-salvaje approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion to move one sentence, otherwise I think this is ready to go!

@siriwatknp @mapache-salvaje
Apply suggestions from code review
c620de5 
Co-authored-by: Sam Sycamore <71297412+mapache-salvaje@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@siriwatknp siriwatknp merged commit b9185c8 into mui:master Feb 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapache-salvaje mapache-salvaje mapache-salvaje approved these changes

@ZeeshanTamboli ZeeshanTamboli Awaiting requested review from ZeeshanTamboli

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui] Deprecate *Component and *Props props
5 participants
@siriwatknp @mui-bot @ZeeshanTamboli @mapache-salvaje @sai6855