Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][MenuList] Do not react to an event with modifier key pressed #43505

Merged
merged 2 commits into from
Aug 30, 2024
Merged

[material-ui][MenuList] Do not react to an event with modifier key pressed #43505

merged 2 commits into from
Aug 30, 2024

Conversation

MateuszGroth
Copy link
Contributor

@MateuszGroth MateuszGroth commented Aug 28, 2024 •
edited by ZeeshanTamboli
Loading

Fixes #43215

@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43505--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 04b2979

@zannager zannager added component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 29, 2024
@zannager zannager requested a review from mnajdova August 29, 2024 14:01
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][MenuList] do not react to an event with modifier key pressed [material-ui][MenuList] Do not react to an event with modifier key pressed Aug 30, 2024
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Aug 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request in Material UI! Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 00eb6b9 into mui:master Aug 30, 2024
19 checks passed
@MateuszGroth
Copy link
Contributor Author

It's a great first pull request in Material UI! Thank you for working on it!

Thanks!

@MateuszGroth MateuszGroth deleted the menu-prevent-default-with-ctrl-key branch September 5, 2024 08:00
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Sep 26, 2024
Merged
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Menu] After opening Menu, it is not possible to refresh page by ctrl + R
4 participants
@MateuszGroth @mui-bot @ZeeshanTamboli @zannager