Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Menu,Popover] Fix Backdrop props descriptions #43503

Merged
merged 4 commits into from
Aug 30, 2024
Merged

[material-ui][Menu,Popover] Fix Backdrop props descriptions #43503

merged 4 commits into from
Aug 30, 2024

Conversation

Michael-Hutchinson
Copy link
Contributor

fix: update popover component with deprecated props and types

Closes: 43222

@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43503--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 96a2ebe

@zannager zannager added component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. labels Aug 29, 2024
@zannager zannager requested a review from DiegoAndai August 29, 2024 14:02
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material customization: dom Component's DOM customizability, e.g. slot labels Aug 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Menu,Popover] slotProps cannot modify backdrop slot [material-ui][Menu,Popover] Fix Backdrop props descriptions Aug 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 8b8732e into mui:master Aug 30, 2024
22 checks passed
@Michael-Hutchinson Michael-Hutchinson deleted the fix/slotProps-cannot-modify-backdrop-slot branch August 30, 2024 13:56
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Sep 26, 2024
Merged
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. customization: dom Component's DOM customizability, e.g. slot package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Menu,Popover] slotProps cannot modify backdrop slot
4 participants
@Michael-Hutchinson @mui-bot @ZeeshanTamboli @zannager