Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all dependencies to react@16 #8801

Closed
oliviertassinari opened this issue Oct 22, 2017 · 6 comments
Closed

Migrate all dependencies to react@16 #8801

oliviertassinari opened this issue Oct 22, 2017 · 6 comments
Assignees
Labels
external dependency Blocked by external dependency, we can’t do anything about it

Comments

@oliviertassinari
Copy link
Member

We are almost there. The only part missing is the test suite, 1200+ tests to migrate 😱.
It's going to be painful but let's do it! 💪

@leMaik
Copy link
Member

leMaik commented Oct 23, 2017

@oliviertassinari What exactly needs to be migrated? Would you mind creating a TODO list to let us know where we can help you? 👍

@oliviertassinari
Copy link
Member Author

I still have 110 tests that are red and need to pass. The biggest blocker seems to be related to Portal enzymejs/enzyme#1150. By migrated, I simply mean making the tests green.

@oliviertassinari
Copy link
Member Author

I will push the branch as far as I can. But I will most likely not be able to complet it. This is my third iteration on the topic. If I fail, I will simply retro port the changes with react@15 so we move forward, one step at the time.

@leMaik
Copy link
Member

leMaik commented Oct 23, 2017

@oliviertassinari Enzyme not supporting portals is a somewhat major blocking issue. I don't really get why nobody over there seems to bother about it. 😕

@oliviertassinari
Copy link
Member Author

@leMaik I should manage to upgrade to enzyme@3. Only 4 more failing tests to fix. Then we are going to have to wait for portal support.

@oliviertassinari oliviertassinari added Priority: + external dependency Blocked by external dependency, we can’t do anything about it and removed Priority: ++ labels Oct 23, 2017
@oliviertassinari
Copy link
Member Author

I'm gonna resume the effort. I'm gonna try to code branch the portal code for the tests. It might reduce the test coverage but it should allow us to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

2 participants