Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectField] Component re-render breaks keyboard navigation #6038

Closed
Floriferous opened this issue Jan 30, 2017 · 2 comments
Closed

[SelectField] Component re-render breaks keyboard navigation #6038

Floriferous opened this issue Jan 30, 2017 · 2 comments
Labels
component: select This is the name of the generic UI component, not the React module!

Comments

@Floriferous
Copy link
Contributor

When using the keyboard to navigate the SelectField dropdown, for example:

  • Using tab to scroll through possible MenuItems
  • Typing to alphabetically get the first matching MenuItem

if a parent component triggers a re-render during this navigation, the "focused" MenuItem automatically reverts to the previously selected value.

Proper use of shouldComponentUpdate solves this, however i'm not sure this should be necessary.

  • Material-UI: 0.16.6
  • React: 15.4.1
  • Browser: Safari & Chrome
@oliviertassinari oliviertassinari added the component: select This is the name of the generic UI component, not the React module! label Feb 2, 2017
@lucasbento
Copy link

I'm not able to reproduce your issue, can you please provide a working example so we can help you out?

@lucasbento lucasbento added the waiting for 👍 Waiting for upvotes label Feb 3, 2017
@oliviertassinari
Copy link
Member

I'm closing the issue for inactivity. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants