Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events are broken while using external modules in webpack configuration #5253

Closed
OshotOkill opened this issue Sep 26, 2016 · 3 comments
Closed
Labels
bug 🐛 Something doesn't work

Comments

@OshotOkill
Copy link

Versions

  • Material-UI: 0.15.4
  • React: 15.3.2
  • Browser: Chrome 53.0.2785.116 m (64-bit)

Problem description

While I decided to change react and react-dom to be external modules, I found the some of the click events are no longer work. However the app could run normally without warnings before I did that. I've checked some issues like #3176 and #4342 but don't find the answer.

Steps to reproduce

I've changed my configs like this:

HTML

4

webpack.config.dev.js

3

WARNINGS

2

Weird is, some of the buttons could work while others are not. I really don't understand what exactly were the breaks after I quoted react and react-dom from externals.

@aeneasr
Copy link

aeneasr commented Nov 9, 2016

I am experiencing the same issue and I think it is explained with this comment: #3176 (comment)

@YochayCO
Copy link

YochayCO commented Dec 8, 2016

Any progress with this? I just started using material ui and got this exact issue

@oliviertassinari
Copy link
Member

We have removed the react-tap-event-plugin dependency on the v1-beta branch, the issue is gone.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

4 participants