Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] TableRowColumn behaves buggy with bigger texts #5163

Closed
arjshiv opened this issue Sep 12, 2016 · 3 comments
Closed

[Table] TableRowColumn behaves buggy with bigger texts #5163

arjshiv opened this issue Sep 12, 2016 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@arjshiv
Copy link

arjshiv commented Sep 12, 2016

Problem description

The text-overflow: ellipsis condition is no longer applying the correct overflow style to text int he TableRowColumn component

Steps to reproduce

Create a Table with a TableRowColumn that has a small width and fill it with a very long string and you'll see that it doesn't overflow correctly

Versions

  • Material-UI: 0.16.0-rc1
  • React: 15.2.1
  • Browser: Chrome

Workaround + Fix

We will need to add overflow: hidden to the TableRowColumn style in https://github.com/callemall/material-ui/blob/master/src/Table/TableRowColumn.js

i.e.

Previous

root: {
      ...
      textOverflow: 'ellipsis',
    },

Proposed

root: {
      ...
      textOverflow: 'ellipsis',
      overflow: 'hidden',
    },

Happy to submit a PR for this minor fix.

@arjshiv arjshiv changed the title TableRowColumn text-overflow ellipsis needs additional condition [TableRowColumn][Bug][Style] text-overflow ellipsis needs additional condition Sep 13, 2016
@arjshiv arjshiv changed the title [TableRowColumn][Bug][Style] text-overflow ellipsis needs additional condition [TableRowColumn][Bug][Style] text-overflow ellipsis needs additional style condition Sep 13, 2016
@avaragado
Copy link

Sadly this bug shipped in 0.16.0. It's not mentioned in the breaking changes for that release, so I guess nobody saw the issue.

@InsidersByte
Copy link

+1

@lucasbento lucasbento changed the title [TableRowColumn][Bug][Style] text-overflow ellipsis needs additional style condition [Table] TableRowColumn behaves buggy with bigger texts Oct 13, 2016
@lucasbento lucasbento added bug 🐛 Something doesn't work duplicate This issue or pull request already exists component: table This is the name of the generic UI component, not the React module! labels Oct 13, 2016
@lucasbento
Copy link

Duplicated of #5377 and fixed on #5378.

@oliviertassinari oliviertassinari removed bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! labels Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants