-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] TabTemplate to use 100% height #5094
Comments
I used this solution #2085, it worked for me |
Hiya, thanks will give it a go, very much appreciated. |
This is a fairly common issue with the tabs component. Maybe the docs could be improved a little? The
I think this is a little vague. linking to the default tab template could be a great start. Adding a little info about the default tab template's implementation would be nice too. However, overriding the component that changes the visibility of the tab might be an overkill for these kind of problems, not to mention error prone. Why not have a new prop called |
It would be great if we could specify the style of template and gets my vote ;) |
An initial migration of the |
When you use the default tab template as part of Tabs the styling in the code uses 100% width, but no 100% height. Meaning if you then want all your other components to get the height allocated under the tab template div you can't get at it when you use 100% height for children under the tab template div.
Steps to reproduce
Simply create a tab and add some child to the tab (set the height property to 100% of the child - the height of div up till the template is correct, but then the child div can't the height.
Versions
Any help would be appreciated.
Regards,
Mustafa
The text was updated successfully, but these errors were encountered: