Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker] ClassName application not consistent with DatePicker #4579

Closed
solace opened this issue Jun 28, 2016 · 1 comment
Closed

[TimePicker] ClassName application not consistent with DatePicker #4579

solace opened this issue Jun 28, 2016 · 1 comment
Labels
component: time picker This is the name of the generic UI component, not the React module!

Comments

@solace
Copy link

solace commented Jun 28, 2016

Problem description

Currently style applies to the outer element on both DatePicker and TimePicker, but className only applies to the outer element for DatePicker, and flows down to the inner element for TimePicker, which makes this feel somewhat inconsistent.

In #4250, the className property was added to DatePicker so that it applies to the outer div rather than flowing down to the inner elements. Should this also be applied to TimePicker?

Steps to reproduce

Instantiate both a DatePicker and TimePicker element with className and style properties, inspect rendered markup. This is also evident in the respective component files.

Versions

  • Material-UI: 0.15.0
  • React: 15.1.0
  • Browser: Chrome
@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari oliviertassinari added component: time picker This is the name of the generic UI component, not the React module! and removed component: time picker This is the name of the generic UI component, not the React module! labels Nov 15, 2016
@oliviertassinari oliviertassinari changed the title TimePicker ClassName application not consistent with DatePicker [TimePicker] ClassName application not consistent with DatePicker May 16, 2017
@nathanmarks nathanmarks mentioned this issue Aug 22, 2017
Closed
5 tasks
@oliviertassinari
Copy link
Member

Closing for #4796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solace @oliviertassinari