[material-ui] Fix slotProps.transition
types
#45214
Open
+226
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45210
Root cause
The existing slotProps below for transition is not correct:
It's because
TransitionProps
extendsReact.HTMLAttributes<HTMLElement>
that causes the final types to be a union ofTransitionProps
and HTML props. That's whytransition['onExited']
does not exist, see this TypeScript playgroundThis PR fixes the issue by moving
TransitionProps
to the second parameter (theTOverrides
).All
slotProps.transition
should follow: