Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mui/base, a dependency of @mui/lab should also have react@19 as an allowed peer dep #44667

Closed
ddolcimascolo opened this issue Dec 6, 2024 · 2 comments
Labels
package: base-ui Specific to @mui/base

Comments

@ddolcimascolo
Copy link

ddolcimascolo commented Dec 6, 2024

Steps to reproduce

No response

Current behavior

There are npm resolve issues currently because of this, when using react@19. You have properly listed react@19 in the lab package but not in the base package, which is a direct dependency.

Expected behavior

No npm resolve issues

Context

Using @mui/lab with react@19.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: mui base lab react 19

@ddolcimascolo ddolcimascolo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 6, 2024
@ddolcimascolo
Copy link
Author

@mj12albert mj12albert added the package: base-ui Specific to @mui/base label Dec 6, 2024
@mj12albert
Copy link
Member

mj12albert commented Dec 6, 2024

@ddolcimascolo Hey thanks for the PR, we're doing it for the whole monorepo here #42824

@mj12albert mj12albert removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 6, 2024
@mj12albert mj12albert closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base-ui Specific to @mui/base
Projects
None yet
Development

No branches or pull requests

2 participants