Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more compatible with Terser Mangler #42974

Closed
salivity opened this issue Jul 16, 2024 · 2 comments
Closed

Make more compatible with Terser Mangler #42974

salivity opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information

Comments

@salivity
Copy link

salivity commented Jul 16, 2024

Summary

Remove the incompatible function calls as defined by Terser at https://github.com/terser/terser, Terser Mangler breaks when using properties = true

Examples

Quote from Terser Github Page, tested myself this seems to be the avoidable problem.

"
Avoid calling functions like defineProperty or hasOwnProperty, because they refer to object properties using strings and will break your code if you don't know what you are doing.
"

Motivation

Improve the compression using Terser Mangler make the code more secure in the rest of the main web pack bundle.

Search keywords: terser,mangler,hasownproperty,defineProperty

@salivity salivity added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 16, 2024
@zannager zannager added the package: material-ui Specific to @mui/material label Jul 17, 2024
@brijeshb42
Copy link
Contributor

Could you point out the relevant code in our codebase so that we can take look ?

@mnajdova mnajdova assigned brijeshb42 and unassigned mnajdova Jul 29, 2024
@brijeshb42 brijeshb42 added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 29, 2024
Copy link

github-actions bot commented Aug 5, 2024

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

@github-actions github-actions bot closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

4 participants