Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] CSS modules customization guide is incomplete #42941

Open
oliviertassinari opened this issue Jul 15, 2024 · 4 comments
Open
Labels
customization: css Design CSS customizability docs Improvements or additions to the documentation dx Related to developers' experience ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 15, 2024

Related page

https://mui.com/material-ui/integrations/interoperability/#css-modules

Kind of issue

Missing information on how to customize

Issue description

We should be covering how to use custom pseudo-classes, e.g. .Mui-selected. See https://stackoverflow.com/questions/78720445/how-to-target-mui-selected-state-class-using-css-modules/78720582 as the problem. See how https://mantine.dev/styles/css-modules/#referencing-global-class-names better explains it.

Context

I saw this from https://discord.com/channels/1131323012554174485/1259813365950189720

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page customization: css Design CSS customizability docs Improvements or additions to the documentation labels Jul 15, 2024
@ZeeshanTamboli
Copy link
Member

I'll add the "ready to take" label for a contribution from the community.

@ZeeshanTamboli ZeeshanTamboli added ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 19, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] CSS modules customization guide is incomplete [docs][material-ui] CSS modules customization guide is incomplete Jul 19, 2024
@oliviertassinari oliviertassinari added dx Related to developers' experience and removed support: docs-feedback Feedback from documentation page labels Jul 19, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 19, 2024

I'm not sure a community contribution can truly help here. I would expect a rewrite of the whole Style library interoperability integration docs. It will take a good focus.

@wojtek35
Copy link

I would like to start working on this issue and update the docs. I could update the CSS Modules section with a better explanation of the :global selector. If needed I could assist with rewriting the rest of docs

@ZeeshanTamboli
Copy link
Member

@wojtek35 Feel free to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: css Design CSS customizability docs Improvements or additions to the documentation dx Related to developers' experience ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

No branches or pull requests

4 participants