Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Disable the translations #33445

Closed
2 tasks done
mbrookes opened this issue Jul 9, 2022 · 6 comments · Fixed by #34820
Closed
2 tasks done

[docs] Disable the translations #33445

mbrookes opened this issue Jul 9, 2022 · 6 comments · Fixed by #34820
Assignees
@mnajdova
Labels
docs Improvements or additions to the documentation l10n localization priority: important This change can make a difference

Comments

@mbrookes
Copy link
Member

mbrookes commented Jul 9, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

The language menu, redirection, and cookie code should be disabled. At some point we might consider removing the i18n infrastructure.

Examples 🌈

N/A

Motivation 🔦

The two remaining translations (Brazilian Portuguese and Chinese) are at ~25% and declining. We have been unable to attract enough translators to keep up with changes, never mind catch up on the delta to 100%.

Partially translated docs are worse than fully translated. While paying for professional translations might be an option, it would also have an ongoing cost, and it seems unlikely that we would recoup the investment in addition sales.
@mbrookes mbrookes added status: waiting for maintainer These issues haven't been looked at yet by a maintainer docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 9, 2022
@flaviendelangle
Copy link
Member

On X we have very outdated translations on the pickers that I would also like to remove

@mbrookes mbrookes added the priority: important This change can make a difference label Jul 28, 2022
@mbrookes

This comment was marked as resolved.

Sign in to view
@flaviendelangle
Copy link
Member

Yes I am talking about the doc
Here is the pr doc for instance

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 19, 2022 •
edited
Loading

For the implementation of this, I believe that we will need to:

a. Add 301 for all the URLs that are going to become 404, e.g. https://mui.com/pt/careers/ should be a 301 to https://mui.com/careers/
b. Remove the alternate hrefLang from the <html>, so that we don't instruct bot crawlers to dead ends.

material-ui/docs/src/modules/components/Head.js

Line 60 in ea83824

hrefLang={userLanguage2}

c. Remove the automatic locale redirection

material-ui/docs/pages/_app.js

Line 62 in ea83824

window.location =

@oliviertassinari oliviertassinari added the l10n localization label Aug 22, 2022
@oliviertassinari oliviertassinari mentioned this issue Aug 22, 2022
Closed
2 tasks
@mnajdova mnajdova self-assigned this Aug 29, 2022
@mnajdova mnajdova mentioned this issue Sep 26, 2022
Merged
1 task
@mbrookes
Copy link
Member Author

mbrookes commented Oct 5, 2022

Hi @mnajdova When do you think you might be able to get to this?

@mnajdova
Copy link
Member

I can start on it next week. We have it in our roadmap for this quarter, but happy to start with it earlier.

@mnajdova mnajdova mentioned this issue Oct 19, 2022
Merged
@oliviertassinari oliviertassinari mentioned this issue Oct 19, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnajdova mnajdova

Labels
docs Improvements or additions to the documentation l10n localization priority: important This change can make a difference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Disable translations mnajdova/material-ui
4 participants
@mbrookes @oliviertassinari @flaviendelangle @mnajdova