Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoComplete] Progress indicator when search is in progress. #2340

Closed
vijayrawatsan opened this issue Dec 2, 2015 · 6 comments
Closed

[AutoComplete] Progress indicator when search is in progress. #2340

vijayrawatsan opened this issue Dec 2, 2015 · 6 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@vijayrawatsan
Copy link

Show some kind of pregress indicator when search is in progress.
@oliviertassinari
Copy link
Member

What about adding a loading(Boolean) property?

@vijayrawatsan
Copy link
Author

Shouldn't it be showing a loading till the promise resolves.

@oliviertassinari
Copy link
Member

I think that handling the state of the dataSource should be the responsibility of the application, not material-ui.
And I may be wrong, but I think that this component do not handle promise.

@vijayrawatsan
Copy link
Author

@oliviertassinari yes you are right. No promises anymore. I wrote my own wrapper around dropdown a while back. I guess I will have to update my code.
Yep loading property would be nice.

@alitaheri alitaheri added the new feature New feature or request label Dec 9, 2015
@tirsen
Copy link

tirsen commented Dec 18, 2015

+1 loading property would be nice. Or at least an example of how the dataSource can show some pretty progress indicator.

@avocadowastaken avocadowastaken mentioned this issue Sep 23, 2016
Closed
@oliviertassinari oliviertassinari changed the title [AutoComplete] - Progress indicator when search is in progress. [AutoComplete] Progress indicator when search is in progress. Dec 18, 2016
@mbrookes
Copy link
Member

This will be addressed by composability in the next branch. Closing as addressed by #5062.

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tirsen @mbrookes @vijayrawatsan @oliviertassinari @alitaheri